feat(validations): raise a transaction error when too many witnesses are requested #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcpu-github
force-pushed
the
too-many-witnesses
branch
from
6563e08
to
d84e51a
Compare
drcpu-github
force-pushed
the
too-many-witnesses
branch
from
d84e51a
to
ea4e2a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves as a proof-of-concept of how we could validate that a data request does not request too many witnesses. The threshold is hard-coded to 1/4th of the amount of validators.
It is probably more convenient to just pass the validator count rather than the full Stakes Tracker. However, I wanted to have this PR serve as a test on how to pass the Stakes Tracker as an argument since that will be required for other validation functions.
The JSON-RPC CLI and wallet cannot really access the Stakes Tracker, so they pass it a None value. If the implementation were to be simplified to pass the validator count as a single number, they could presumably query it from the node before validating the data request.