Upgrade witnet-rust docker image base (ubuntu) #2442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesedepece
requested changes
Mar 21, 2024
| jq | ||
|
|
||
| # Clean up apt packages so the docker image is as compact as possible | ||
| RUN apt-get clean && apt-get autoremove | ||
| RUN apt clean && apt autoremove |
There was a problem hiding this comment.
It is customary in the GNU world not to use apt in scripts. This is explained in its man page and the command will even complain about it when it detects that the current tty isn't interactive.
There was a problem hiding this comment.
@aesedepece we can revert it for the clean/autoremove but for the install/update we have to use it cuz the package is no longer available in apt-get but available in apt in the new update :/
There was a problem hiding this comment.
i can also isolate that specific package in it's own step but that would inflate the image size and i wouldn't recommend it
aesedepece
approved these changes
May 27, 2024
|
Merged in as 0e1be39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.