Add StakeTransaction #2401
Open
Add StakeTransaction #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
force-pushed
the
feat/stake-tx
branch
8 times, most recently
from
c64ab6d
to
e724019
Compare
aesedepece
requested changes
Oct 18, 2023
Comment on lines
+1823
to
+1813
| // TODO: Move validations to a visitor | ||
| // // Execute visitor | ||
| // if let Some(visitor) = &mut visitor { | ||
| // let transaction = Transaction::ValueTransfer(transaction.clone()); | ||
| // visitor.visit(&(transaction, fee, weight)); | ||
| // } |
Comment on lines
+190
to
+191
| // #[serde(rename = "stake")] | ||
| // Stake(StakeData), |
Tommytrg
force-pushed
the
feat/stake-tx
branch
3 times, most recently
from
2cc250d
to
a21c0a8
Compare
aesedepece
requested changes
Oct 20, 2023
Comment on lines
+2258
to
+2263
| /// # use witnet_data_structures::chain::{TransactionsPool, Hash}; | ||
| /// # use witnet_data_structures::transaction::{Transaction, StakeTransaction}; |
There was a problem hiding this comment.
Because it's also comented in the other examples
Comment on lines
+112
to
+124
| let out_value = &st_tx.body.output.value | ||
| - &st_tx | ||
| .body | ||
| .change | ||
| .clone() | ||
| .unwrap_or(Default::default()) | ||
| .value; | ||
|
|
||
| if out_value > in_value { | ||
| Err(TransactionError::NegativeFee.into()) | ||
| } else { | ||
| Ok(in_value - out_value) | ||
| } |
There was a problem hiding this comment.
I don't get this logic. Why subtracting the change? The change is also part of the transaction value.
| failure::Error, | ||
| > { | ||
| // Check that the amount of coins to stake is equal or greater than the minimum allowed | ||
| if st_tx.body.output.value < MIN_STAKE_NANOWITS { |
There was a problem hiding this comment.
See my former comment on consistency of ? vs. return syntax inside the same function.
Tommytrg
force-pushed
the
feat/stake-tx
branch
from
626ca59
to
3c9c2fa
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validations
Transaction
Block