Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated TypeScript from 4.6.0 to 4.8.2 #387

Closed

Conversation

jonathantneal
Copy link
Contributor

Changes

  • This updates the TypeScript dependencies from 4.6.0 to 4.8.2
  • Starting in TypeScript 4.7.x, package.json exports are supported.
  • During build, I noticed a missing interface for InlayHintsOptions, which was then added with citation from the TypeScript Fourslash suite.

Testing

Followed CONTRIBUTING.md.

Docs

dependency update only

@jonathantneal jonathantneal requested a review from a team as a code owner August 27, 2022 16:59
@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2022

🦋 Changeset detected

Latest commit: 6600b85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/language-server Minor
astro-vscode Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Princesseuh
Copy link
Member

Princesseuh commented Aug 27, 2022

Hello! Thank you for this PR. Unfortunately, updating to the latest TypeScript version is not that easy.

Some changes to our module resolution cache and our code actions are needed to properly support 4.7. Additionally, our current language services force moduleResolution to node which is not ideal

If you're interested in tackling this, I recommend checking out how Svelte's tools did it. But be aware that we don't do things exactly the same way in the module resolution department

@jonathantneal
Copy link
Contributor Author

Thanks for the quick review, @Princesseuh. To clarify, would the guidance be to apply similar kinds of changes as sveltejs/language-tools#1526? I want to be sure I’m looking at the right change Svelte made. If you’re not sure, I can ask later this week, too. No rush, and again, thank you for the incredibly fast review.

@Princesseuh
Copy link
Member

Thanks for the quick review, @Princesseuh. To clarify, would the guidance be to apply similar kinds of changes as sveltejs/language-tools#1526? I want to be sure I’m looking at the right change Svelte made. If you’re not sure, I can ask later this week, too. No rush, and again, thank you for the incredibly fast review.

Yep! That's the right PR. Additionally, support for group aware organize imports should be considered for full support sveltejs/language-tools#1515

I'm okay with that one being tackled separately if you prefer not to, it's alright. I can tackle it myself låter

@Princesseuh
Copy link
Member

#389 makes this PR unnecessary. We'll still need to add support for node16 resolution and group aware imports, but it'll be tackled separately. Thank you for making this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants