feat: bumped typescript-eslint to v6 stable 馃コ #7626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
JoshuaKGoldberg
commented
Jul 11, 2023
| @@ -72,8 +72,6 @@ export function eventError({ | |||
| cliCommand: cmd, | |||
| isFatal: isFatal, | |||
| anonymousMessageHint: | |||
| // https://github.com/typescript-eslint/typescript-eslint/issues/4820 | |||
| // eslint-disable-next-line @typescript-eslint/prefer-optional-chain -- errorData may be false | |||
There was a problem hiding this comment.
Explaining:
- feat(eslint-plugin): [prefer-optional-chain] handle cases where the first operands are unrelated to the rest of the chain and add type info聽typescript-eslint/typescript-eslint#6397 made the rule more powerful and so it started flagging more things
- I disabled the rule in
.eslintrc.cjs, so it doesn't need to be disabled here.
bluwy
approved these changes
Jul 12, 2023
ematipico
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bumps to the stable config now that typescript-eslint v6 is released as stable.
I don't think this needs a changeset, since the only package code it touches is to remove a couple of comments?
Testing
Linting-only change, no tests needed I think?
Docs
Internal-only change, no docs needed I think?