Fix client only import with importsNotUsedAsValues error #5639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix #5541
fix #5624
If a framework component as side effects that access browser globals, and is used as
client:only
, Astro should treeshake the import of that component import to prevent the side effect from running in SSR.#5553 accidentally break this as
"importsNotUsedAsValues": "error"
is respected when specified in the tsconfig, causing the import to be preserved and not treeshaken.This PR forces
"importsNotUsedAsValues": "error"
Testing
updated client-only test
Docs
n/a bug fix