fix(types): add server.headers typing
#5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7e90645 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
SegaraRai
force-pushed
the
fix/server-headers-typing
branch
2 times, most recently
from
1472382
to
388772f
Compare
SegaraRai
force-pushed
the
fix/server-headers-typing
branch
from
388772f
to
e9782d9
Compare
|
CI is failing due to timeout or socket hangup. |
sarah11918
reviewed
Dec 20, 2022
packages/astro/src/@types/astro.ts
Outdated
| * @name server.headers | ||
| * @typeraw {OutgoingHttpHeaders} | ||
| * @default `{}` | ||
| * @version 1.70.0 |
There was a problem hiding this comment.
Suggested change
| * @version 1.70.0 | |
| * @version 1.7.0 |
Just checking on this. (also in line 328)
bluwy
reviewed
Dec 21, 2022
bluwy
approved these changes
Dec 21, 2022
|
@sarah11918 Looks like your commented line has been updated. Just need docs approval for this. |
sarah11918
approved these changes
Dec 27, 2022
|
@matthewp Docs approved! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added
server.headerstyping.This is needed to use
server.headersalong withdefineConfig.Testing
I'm sorry but I couldn't figure out how to add TS test so no tests were added.
Docs
I'm not sure about docs generation.
/cc @withastro/maintainers-docs for feedback!