Show warning about hydrating Astro components in build #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 26f1e97 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
approved these changes
Dec 1, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bit of a lazy fix. I was hoping to be able to provide more information in the warning, but much like what I faced in #5316, we don't have access to much there. In the future, I'd like to investigate a larger endeavour there to see if we can drill down info for error / warnings reporting (or bubble up warnings and errors, maybe?)
For now this is still an improvement. It's not that big of an issue that the location isn't in the message as the warning will show up when you visit the page / build it so you'll know either way in which file it is. In the future we'll also add an editor warning for this, which should also help users avoid this situation!
Fix #4090
Testing
Tested manually
Docs
N/A