Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not omitted extension in url metadata for newly added markdown files in development #5238

Merged

Conversation

MoustaphaDev
Copy link
Member

Changes

Closes #5228

Testing

  • After get the result of a glob import of all the markdown files using Astro.glob we check if any of the markdown modules url metadata ends with one of the markdown extensions.
  • The result of that operation is passed to a data attribute that should be false if none of urls ends with a markdown.

Docs

Nothing changes, it's a bug fix

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022

🦋 Changeset detected

Latest commit: 83cb7ad

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 28, 2022
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@matthewp matthewp merged commit 26ff429 into withastro:main Oct 28, 2022
@astrobot-houston astrobot-houston mentioned this pull request Oct 28, 2022
@MoustaphaDev MoustaphaDev deleted the fix-markdown-alternative-extension-url branch October 28, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returned url constant from newly added alternative markdown extensions includes the extension of the file
2 participants