Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: post API routes in SSG should warn or error during dev mode #4878

Merged
merged 8 commits into from Sep 27, 2022
Merged

fix: post API routes in SSG should warn or error during dev mode #4878

merged 8 commits into from Sep 27, 2022

Conversation

rishi-raj-jain
Copy link
Contributor

@rishi-raj-jain rishi-raj-jain commented Sep 26, 2022 •
edited

fixes #4875

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022 •
edited

🦋 Changeset detected

Latest commit: c4c30ee

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 26, 2022
@rishi-raj-jain rishi-raj-jain changed the title Update endpoint.ts fix: post API routes in SSG should warn or error during dev mode Sep 26, 2022
okikio
okikio approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@okikio okikio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@matthewp matthewp merged commit 90c2072 into withastro:main Sep 27, 2022
@astrobot-houston astrobot-houston mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

@okikio okikio okikio approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

post API routes in SSG should warn or error during dev mode
3 participants
@rishi-raj-jain @matthewp @okikio