Prevent /undefined catch-all routes in dev #4873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #4796
In dev, for pages declared like
pages/[...slug].astro
, ifslug
isundefined
, only serve athttp://localhost:3000
andhttp://localhost:3000/
. Don't servehttp://localhost:3000/undefined
This PR makes
undefined
and"undefined"
as 2 distinct static paths to differentiate them, by not stringifyingundefined
.Note: In build,
http://localhost:3000/undefined
is never built. So this PR makes dev consistent with build.Testing
Added a test under
routing-priority
Docs
N/A.