Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define toStringTag another way #4855

Merged
merged 2 commits into from Sep 23, 2022
Merged

Define toStringTag another way #4855

merged 2 commits into from Sep 23, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Prevents errors when not using skipLibCheck

Testing

  • Tests should continue to pass

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2022 •
edited

🦋 Changeset detected

Latest commit: 7d388c1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 23, 2022
Princesseuh
Princesseuh approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is essentially a hack, but I'll allow it

@matthewp
Copy link
Contributor Author

@Princesseuh Not a hack :) TS is wrong here, Symbol.toStringTag is a protocol that can be put on any object to control how toString() works. I'd use a different method of brand-checking but we already do it this way in a couple of other places so changing it here because of a TS bug seems wrong to me.

@matthewp
Copy link
Contributor Author

Going to file a bug in TS

@matthewp
Copy link
Contributor Author

microsoft/TypeScript#50923

@matthewp matthewp merged commit 49ca9e1 into main Sep 23, 2022
@matthewp matthewp deleted the prevent-ts-error branch September 23, 2022 17:27
@astrobot-houston astrobot-houston mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Princesseuh Princesseuh Princesseuh approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewp @Princesseuh