Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: No assets folder when outDir outside cwd #4841

Merged
merged 8 commits into from Sep 22, 2022
Merged

fix: No assets folder when outDir outside cwd #4841

merged 8 commits into from Sep 22, 2022

Conversation

rishi-raj-jain
Copy link
Contributor

@rishi-raj-jain rishi-raj-jain commented Sep 22, 2022 •
edited

fixes #4825

Changes

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022 •
edited

🦋 Changeset detected

Latest commit: 980cf9f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 22, 2022
@matthewp
Copy link
Contributor

Thanks! This looks great. We have another PR that's fixing the lint issues, then this can be updated.

@rishi-raj-jain
Copy link
Contributor Author

@matthewp merged the lint fixes

@matthewp
Copy link
Contributor

Thanks! Can you add a changeset? pnpm changeset and make it be a patch.

matthewp
matthewp requested changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changeset, pnpm changeset

@matthewp matthewp merged commit 4b09226 into withastro:main Sep 22, 2022
@astrobot-houston astrobot-houston mentioned this pull request Sep 22, 2022
Merged
@rishi-raj-jain rishi-raj-jain changed the title Resolves #4825 fix: No assets folder when outDir outside cwd Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No assets folder when outDir outside cwd
2 participants
@rishi-raj-jain @matthewp