Vendor Vite's importMeta.d.ts inside our repo to workaround issue with tsc on Linux
#4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 92f78fb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
reviewed
Aug 26, 2022
bluwy
approved these changes
Aug 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
tscdoesn't handle paths with uppercase characters inside tripleslash directives usingtypescorrectly. The TypeScript team is aware of this, but it's been an issue for years now. Renaming the file to use lower case characters works, however this is understandably a breaking change for the Vite team (see vitejs/vite#9827)As such, for now we'll just copy the file in our own repository until Vite 4 comes out. That's okay
Fix #4387
Testing
Tested manually
Docs
N/A