Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS @import test #4454

Merged
merged 10 commits into from Sep 22, 2022
Merged

Add CSS @import test #4454

merged 10 commits into from Sep 22, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 24, 2022

Changes

Testing

Existing e2e test should pass. Also added new css @import test

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2022

🦋 Changeset detected

Latest commit: c66de16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/css Patch
@e2e/error-cyclic Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch
@e2e/third-party-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 24, 2022
@bluwy
Copy link
Member Author

bluwy commented Aug 24, 2022

Hmm looks like the HMR changes caused some tests to fail. Making draft for now but will check again.

@bluwy bluwy marked this pull request as draft August 24, 2022 14:13
@bluwy bluwy mentioned this pull request Sep 14, 2022
@bluwy bluwy marked this pull request as ready for review September 14, 2022 14:14
@bluwy
Copy link
Member Author

bluwy commented Sep 14, 2022

This PR is good now. I skipped the test in windows for now as it's not quite convenient for me to debug that yet 😬

@bluwy bluwy marked this pull request as draft September 16, 2022 16:52
@matthewp matthewp marked this pull request as ready for review September 22, 2022 18:28
@matthewp matthewp merged commit 6a1a17d into main Sep 22, 2022
@matthewp matthewp deleted the css-hmr-test branch September 22, 2022 19:06
@astrobot-houston astrobot-houston mentioned this pull request Sep 22, 2022
@bluwy
Copy link
Member Author

bluwy commented Sep 23, 2022

Oh I thought they were some issues in windows but glad to know it's just flake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants