Fix changesets destroying our Astro codeblocks in changelogs #4227
Conversation
|
github-actions
bot
added
the
pkg: astro
| // not support our plugin and it ends up doing more harm than good. As such, we'll disable our plugin for changelogs | ||
| files: ['CHANGELOG.md'], | ||
| options: { | ||
| plugins: [], |
There was a problem hiding this comment.
Since we do it that way, our format command will still format CHANGELOG.md because it override this. As such, this will only impact formatting inside the editor and when not using our format command
| @@ -0,0 +1,32 @@ | |||
| // Heads up: This file should be renamed to `.cjs`, however if we did that, changesets wouldn't be able to load it | |||
There was a problem hiding this comment.
.cjs config files were added in Prettier 2.1 🙈
|
Might not be needed in the future, changesets is fixing this issue changesets/changesets#905 |
Changes
Changesets was mysteriously destroying every Astro code block inside
CHANGELOG.md. This happen because changesets Prettier version is very old and our plugin is not compatible. As such, this PR disable the plugin inside CHANGELOG.mdWhile I was there, I fixed some non-astro code blocks that had been weirdly formatted from back when we didn't have astro codeblocks
Testing
Tested manually
Docs
N/A