Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup to prevent empty slot bug #3496

Merged
merged 4 commits into from Jun 1, 2022
Merged

Update rollup to prevent empty slot bug #3496

merged 4 commits into from Jun 1, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jun 1, 2022

Changes

Testing

Test added

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

🦋 Changeset detected

Latest commit: c664bc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 1, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice sleuthing—I'm really surprised they tried to do this!

@matthewp matthewp merged commit d588bc4 into main Jun 1, 2022
@matthewp matthewp deleted the unused-slot branch June 1, 2022 16:21
@github-actions github-actions bot mentioned this pull request Jun 1, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Update rollup to prevent empty slot bug

* Adds a changeset

* Updated lockfile

* provide import.meta.env.SITE when there are private envs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Error when building Just the Basics starter : Cannot read properties of undefined (reading 'icon')
2 participants