Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make i18n domains stable #11022

Merged
merged 4 commits into from
May 22, 2024
Merged

feat: make i18n domains stable #11022

merged 4 commits into from
May 22, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented May 13, 2024

Changes

This PR removes the experimental flag experimental.i18nDomains

Testing

Current tests should pass

Docs

/cc @withastro/maintainers-docs for feedback!

withastro/docs#8285

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 0835949

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr A PR that includes documentation for review semver: minor Change triggers a `minor` release labels May 13, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@ematipico ematipico added this to the 4.9.0 milestone May 13, 2024
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks right to me! Missing a spot in a test fixture looking at the unit failure

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.8 was all about experimental... 4.9 is unflagging! 🥳

This is giving me lots of practice with changesets, in both directions, and leaving me no excuse for not writing this up as a standard guide. 😅

packages/astro/src/@types/astro.ts Show resolved Hide resolved
.changeset/five-crabs-rhyme.md Outdated Show resolved Hide resolved
ematipico and others added 3 commits May 15, 2024 13:48
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs!

@ematipico ematipico merged commit be68ab4 into main May 22, 2024
14 checks passed
@ematipico ematipico deleted the feat/unflag-i18n-domains branch May 22, 2024 11:06
@astrobot-houston astrobot-houston mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants