feat(astro): experimental astro:env #10974
Merged
+1,594
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
🦋 Changeset detectedLatest commit: e8cbc6c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
!preview astro-env |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
bluwy
reviewed
May 9, 2024
|
!preview astro-env |
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
florian-lefebvre
commented
Jun 3, 2024
sarah11918
reviewed
Jun 3, 2024
sarah11918
reviewed
Jun 3, 2024
sarah11918
reviewed
Jun 3, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
approved these changes
Jun 4, 2024
sarah11918
reviewed
Jun 4, 2024
matthewp
reviewed
Jun 4, 2024
| @@ -382,7 +382,7 @@ async function writeContentFiles({ | |||
| let contentTypesStr = ''; | |||
| let dataTypesStr = ''; | |||
|
|
|||
| const collectionSchemasDir = new URL('./collections/', contentPaths.cacheDir); | |||
| const collectionSchemasDir = new URL('./collections/', settings.dotAstroDir); | |||
There was a problem hiding this comment.
Why are these things changed?
There was a problem hiding this comment.
All codegen related features need to create files in .astro. The path is not content specific so I extracted it to settings to be able to reuse it across content, actions and env. It will also be helpful when I get to work on withastro/roadmap#887
matthewp
reviewed
Jun 4, 2024
| const numberValidator: ValueValidator = (input) => { | ||
| const num = parseFloat(input ?? ''); | ||
| return { | ||
| valid: !isNaN(num), |
There was a problem hiding this comment.
Tested this implementation quite a bit and couldn't find a bug, good job!
matthewp
reviewed
Jun 4, 2024
bluwy
reviewed
Jun 4, 2024
ematipico
approved these changes
Jun 4, 2024
sarah11918
reviewed
Jun 4, 2024
sarah11918
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Made one small suggestion, but I think otherwise the docs pass my checks! Nicely done @florian-lefebvre !
If either @ematipico or @matthewp has suggestions or comments for the technical accuracy/completeness of the docs, feel free to comment! But from an editing standpoint, I'm happy with what's there!
matthewp
approved these changes
Jun 4, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
…nto feat/astro-env
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astro:env. View RFC Astro Env roadmap#894What to review
I'm mostly looking for reviews on
astro:env/setup: https://github.com/withastro/astro/pull/10974/files#diff-d08d0989a863f87bfceda052de858b8d03124b6bfbff8e084ffbef31240bb446, https://github.com/withastro/astro/pull/10974/files#diff-a95d41705ded14985c748b640b26f3226a7c37d714a8f2fe6171252a59e9941eR79-R81, https://github.com/withastro/astro/pull/10974/files#diff-f982c118ef9afa9c2d69b474b2e206e460b62068cccb0061a5b4eccfe81c708bAlso worth reviewing the adapters pr to see how it will be used for real.
Testing
Unit and integration tests
Docs
Added changeset and config reference