Fix viewer utils in order to send only valid XML to the server #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pau-sala-at-wiris
requested review from
carla-at-wiris,
jgonzalez-at-wiris,
jhernandez-at-wiris,
xjiang-at-wiris and
usantos-at-wiris
usantos-at-wiris
changed the title
|
Great way to solve it! Good job! |
usantos-at-wiris
approved these changes
May 13, 2024
jgonzalez-at-wiris
requested changes
May 13, 2024
jhernandez-at-wiris
approved these changes
May 13, 2024
carla-at-wiris
changed the title
carla-at-wiris
requested changes
May 14, 2024
jgonzalez-at-wiris
approved these changes
May 15, 2024
carla-at-wiris
approved these changes
May 15, 2024
taskid #45734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some user inputs were causing the server to fail due to malformed XML. When retrieving MathML, the generated text is transformed into HTML, which is not 100% compatible with XML. The current solution uses the browser's native XMLParser to transform HTML into XML and ensures that only valid XML is sent to the server.
Steps to reproduce
Unit tests
Ui
<math xmlns="http://www.w3.org/1998/Math/MathML"><mo mathvariant="bold" mathcolor="#7F0000" mathsize="48px">«</mo><mo mathvariant="bold" mathcolor="#7F0000" mathsize="48px"><</mo><mo mathvariant="bold" mathcolor="#7F0000" mathsize="48px">»</mo><mo mathvariant="bold" mathcolor="#7F0000" mathsize="48px">></mo><mo mathvariant="bold" mathcolor="#7F0000" mathsize="48px">§</mo><mo mathvariant="bold" mathcolor="#7F0000" mathsize="48px">&</mo><mo mathvariant="bold" mathcolor="#7F0000" mathsize="48px">¨</mo><mo mathvariant="bold" mathcolor="#7F0000" mathsize="48px">"</mo><mo mathvariant="bold" mathcolor="#7F0000" mathsize="48px">'</mo><mo mathvariant="bold" mathcolor="#7F0000" mathsize="48px">'</mo></math><math><mn mathcolor="red">"4</mn><mo>×</mo><mi>x</mi></math>#taskid 45734
Changes.md
fix: change htmlEntitiesToXmlEntities' implementation in order to assure only valid XML