KB-45995: Add workspace config, plugins linting and formatting config. #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usantos-at-wiris
requested review from
carla-at-wiris,
jgonzalez-at-wiris,
jhernandez-at-wiris,
xjiang-at-wiris and
pau-sala-at-wiris
|
For me everything is ok, except Prettier don't format when saving Is better if anyone else could try it |
There was a problem hiding this comment.
The linting README should be updated as well to reflect the current configuration.
There should be a place on documentation where it specifies that Prettier should be installed globally through npm, otherwise there's an error where it says that the package is not found. Ideally, it should be on the package.json instead of having to install it globally, if possible, let's try to go that way.
The autoloading does not autoformat de document and the linter does not show the linting errors on a file.
jhernandez-at-wiris
requested changes
May 9, 2024
Co-authored-by: Jesus H. <79973396+jhernandez-at-wiris@users.noreply.github.com>
…ed yarn format for yarn lint, installed prettier
jgonzalez-at-wiris
approved these changes
May 13, 2024
jhernandez-at-wiris
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing the latest updates to our workspace, including enhanced linting, formatting capabilities, and additional extensions.
Steps to reproduce
Explore the workspace and try formatting existing files or examining recent changes. Test out the newly integrated extensions to identify any additional features you may require.
Please, if you have a suggestion over a desired extension config or issue, let me know!
Also closes branch #KB-45995-fmt
#taskid 45995
Changes.md
feat: Add workspace config and plugins for linting, formating and utilities. #KB-45995