-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve viewer behaviour on errors #951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjiang-at-wiris
requested review from
carla-at-wiris,
jgonzalez-at-wiris,
jhernandez-at-wiris and
usantos-at-wiris
April 23, 2024 10:28
jgonzalez-at-wiris
requested changes
Apr 23, 2024
jhernandez-at-wiris
approved these changes
Apr 23, 2024
jhernandez-at-wiris
approved these changes
Apr 23, 2024
jgonzalez-at-wiris
approved these changes
Apr 23, 2024
xjiang-at-wiris
force-pushed
the
KB-44942
branch
from
April 23, 2024 15:20
39f53e1
to
053ac2b
Compare
carla-at-wiris
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would mix the last two commits and rebase the code with master, since you have there one duplicated commit from master. Apart from that, the code looks great!
jhernandez-at-wiris
approved these changes
May 9, 2024
jgonzalez-at-wiris
requested changes
May 9, 2024
jgonzalez-at-wiris
approved these changes
May 9, 2024
taskid #43208
Co-Authored-By: Jesus H. <79973396+jhernandez-at-wiris@users.noreply.github.com> Co-Authored-By: Jose González <78553646+jgonzalez-at-wiris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To alllow Viewers to accept multiple MathML inputs and not halt execution of remaining formulas if one MathML format encounters an error.
Steps to reproduce
#taskid 43208