feat(demos): Destroy MathType when the editor is destroyed #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usantos-at-wiris
changed the title
usantos-at-wiris
changed the title
carla-at-wiris
requested changes
Apr 9, 2024
packages/devkit/src/modal.js
Outdated
| this.removeListeners(); | ||
| this.overlay.remove(); | ||
| this.container.remove(); | ||
| // Reset propertie to allow open again. |
There was a problem hiding this comment.
Suggested change
| // Reset propertie to allow open again. | |
| // Reset properties to allow open again. |
There was a problem hiding this comment.
Fixed, thanks!
packages/froala/wiris.src.js
Outdated
| @@ -117,6 +123,8 @@ export class FroalaIntegration extends IntegrationModel { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Two unnecessary added lines: 126 & 127
There was a problem hiding this comment.
Fixed, thanks!
| Util.removeElementEvents(eventTarget); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } |
Unnecessary added space
There was a problem hiding this comment.
Fixed, thanks!
|
Please @wiris/squad-mathtype-integrations can I get an additional review on the last commit? about the generic integration |
jgonzalez-at-wiris
requested changes
Apr 22, 2024
usantos-at-wiris
force-pushed
the
KB-44922
branch
from
a71d62c
to
d7ce8e9
Compare
usantos-at-wiris
changed the title
jhernandez-at-wiris
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix ensures that when the editor is closed all the MathType remainings (Modal, Events, Instances) are removed from the DOM.
The issue is fixed on #KB-44922
The branch #KB-44922-test adds additional tools to test the fix.
Steps to reproduce
Follow the next steps to reproduce.
Causes
The issue is caused because the MathType modal is not being removed from the DOM when the editor is destroyed.
#taskid 44922
#Child of taskid 44564