Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CKEditor 5] options passed to setData are ignored #885

Open
jonscheiding opened this issue Feb 3, 2024 · 1 comment
Open

[CKEditor 5] options passed to setData are ignored #885

jonscheiding opened this issue Feb 3, 2024 · 1 comment
Labels
type:bug Something isn't working

Comments

@jonscheiding
Copy link

Description

CKEditor5 setData options are ignored

Environment

Which version of MathType does this happen in?

@wiris/mathtype-ckeditor5@8.7.2

What is the relevant software and their versions?

  • CKEditor 5
  • Any Framework
  • Any Browser
  • Any OS

Steps to reproduce

What are the steps needed to reproduce the bug?

  • Initialize a CKE5 editor with with the MathType plugin added
  • Call editor.setData("<p>new content</p>", { batchType: { isUndoable: true } })
  • Notice that the change cannot be undone

Expected result

The change should be undoable

Actual result

The change is not undoable

Other details

This is because the monkey-patched data.set method is not passing the options on to the inner set method.
@jonscheiding jonscheiding added the type:bug Something isn't working label Feb 3, 2024
@jonscheiding jonscheiding mentioned this issue Feb 3, 2024
Closed
@jonscheiding jonscheiding changed the title CKEditor5: options passed to setData are ignored [CKEditor 5] options passed to setData are ignored Feb 3, 2024
@carla-at-wiris
Copy link
Contributor

Hello @jonscheiding, thank you for reporting the issue and the suggested changes,

Our team took a look at it and will send your proposal to the next step. Once it's ready to release, we'll let you know! Any further issues, please feel free to contact us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ck5): respect options passed to data controller on set examspark/wiris-html-integrations
2 participants
@jonscheiding @carla-at-wiris