Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter to be able to force null_values in TypeTester() #745

Merged
merged 6 commits into from Jul 14, 2021

Commits on Sep 7, 2020

  1. Configuration menu
    Copy the full SHA
    72a946e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d934e5f View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Configuration menu
    Copy the full SHA
    03c20e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Avoid an unexpected AttributeError when pyicu.DateFormat.createTimeIn…

    …stance() returns None
    
    (no idea why it does sometimes: buggy dll?)
    
    Workaround: in case of failure, avoid PyICU use in parsedatetime
    
    Traceback below:
        column_types = TypeTester(force=column_types)
      File "/usr/local/lib/python3.8/site-packages/agate/type_tester.py", line 68, in __init__
        Date(),
      File "/usr/local/lib/python3.8/site-packages/agate/data_types/date.py", line 34, in __init__
        self._constants = parsedatetime.Constants(localeID=self.locale, usePyICU=True)
      File "/usr/local/lib/python3.8/site-packages/parsedatetime/__init__.py", line 2381, in __init__
        self.locale = get_icu(self.localeID)
      File "/usr/local/lib/python3.8/site-packages/parsedatetime/pdt_locales/icu.py", line 100, in get_icu
        result['timeFormats'][x] = icu_tf[x].toPattern()
    AttributeError: 'NoneType' object has no attribute 'toPattern'
    lcorbasson committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    15296f1 View commit details
    Browse the repository at this point in the history
  2. Fix end-of-line spacing

    lcorbasson committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    191929d View commit details
    Browse the repository at this point in the history
  3. Revert "Avoid an unexpected AttributeError when pyicu.DateFormat.crea…

    …teTimeInstance() returns None"
    
    This reverts commit 15296f1.
    lcorbasson committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    e72d554 View commit details
    Browse the repository at this point in the history