Add a parameter to be able to force null_values in TypeTester() #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance() returns None
(no idea why it does sometimes: buggy dll?)
Workaround: in case of failure, avoid PyICU use in parsedatetime
Traceback below:
column_types = TypeTester(force=column_types)
File "/usr/local/lib/python3.8/site-packages/agate/type_tester.py", line 68, in __init__
Date(),
File "/usr/local/lib/python3.8/site-packages/agate/data_types/date.py", line 34, in __init__
self._constants = parsedatetime.Constants(localeID=self.locale, usePyICU=True)
File "/usr/local/lib/python3.8/site-packages/parsedatetime/__init__.py", line 2381, in __init__
self.locale = get_icu(self.localeID)
File "/usr/local/lib/python3.8/site-packages/parsedatetime/pdt_locales/icu.py", line 100, in get_icu
result['timeFormats'][x] = icu_tf[x].toPattern()
AttributeError: 'NoneType' object has no attribute 'toPattern'
…teTimeInstance() returns None" This reverts commit 15296f1.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
null_valuesis a parameter common to all agate types. Being able to specify it directly in the constructor avoids any use of private members like _possible_types to get the effect of choosing the list of null values while keeping agate's default order of types.