Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] WNT API documentation #87

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[WIP] WNT API documentation #87

wants to merge 3 commits into from

Conversation

PFigs
Copy link
Contributor

@PFigs PFigs commented Oct 10, 2019

There are still quite a few things to fix:

  • check table numbering
  • check if example request and example responses have a uniform flow
  • add comments around request/responses to help future doc updates
  • review equations (should we embed them from a 3rd party service?)?
  • render (equation) symbols in the text

@PFigs PFigs added apis/wnt Issues related to wnt public api documentation Issues related to documentation of the package and repo labels Oct 10, 2019
@PFigs PFigs added this to the v1.3.0 milestone Oct 10, 2019
.
}

mes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t use literal URLs without angle brackets

Other clients are notified about the users related changes (except
password changes) via real time situation connection.

### Metadata service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 1 space before this heading’s content


This document is compliant with WNT backend version 2.0.

## Backend interface components
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 1 space before this heading’s content

- [Pixels to WGS84](#pixels-to-wgs84)
- [WGS84 to ECEF conversion](#wgs84-to-ecef-conversion)
- [ECEF to WGS84 conversion](#ecef-to-wgs84-conversion)
- [References](#references)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 2 spaces

- [WGS84 to pixels](#wgs84-to-pixels)
- [Pixels to WGS84](#pixels-to-wgs84)
- [WGS84 to ECEF conversion](#wgs84-to-ecef-conversion)
- [ECEF to WGS84 conversion](#ecef-to-wgs84-conversion)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 2 spaces

- [Time series service data](#time-series-service-data)
- [Example CURL command to query data](#example-curl-command-to-query-data)
- [Example column names decoding](#example-column-names-decoding)
- [Basic data flow and real time situation data](#basic-data-flow-and-real-time-situation-data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 2 spaces

- [Real time situation service authentication](#real-time-situation-service-authentication)
- [Time series service data](#time-series-service-data)
- [Example CURL command to query data](#example-curl-command-to-query-data)
- [Example column names decoding](#example-column-names-decoding)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 2 spaces

- [Get components information](#get-components-information)
- [Real time situation service authentication](#real-time-situation-service-authentication)
- [Time series service data](#time-series-service-data)
- [Example CURL command to query data](#example-curl-command-to-query-data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 2 spaces

- [Get scratchpad status](#get-scratchpad-status)
- [Get components information](#get-components-information)
- [Real time situation service authentication](#real-time-situation-service-authentication)
- [Time series service data](#time-series-service-data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 2 spaces

- [Send data message](#send-data-message)
- [Get scratchpad status](#get-scratchpad-status)
- [Get components information](#get-components-information)
- [Real time situation service authentication](#real-time-situation-service-authentication)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect list-item indent: add 2 spaces

Comment on lines +20 to +81
+-----------------------------------+-----------------------------------+
| Version | Description |
+===================================+===================================+
| 1.6 | Initial version |
+-----------------------------------+-----------------------------------+
| 1.7 | Updated for WNT 1.7 |
| | |
| | - Removed warning from *Get |
| | areas* chapter and updated |
| | the response, as the issue |
| | was fixed. |
| | |
| | - Removed note about *Set node |
| | metadata* method only to |
| | accept single entry, as it is |
| | not true anymore. |
+-----------------------------------+-----------------------------------+
| 2.0 | Updated for WNT 2.0 |
| | |
| | - Added *protocol version* |
| | table. |
| | |
| | - Updated *protocol version* |
| | to 3. |
| | |
| | - Added note about |
| | *analytics\_packet* |
| | measurement change. |
| | |
| | - Added *Get components |
| | information* and *Get |
| | scratchpad status* methods. |
| | |
| | - Added floor plan image size |
| | to *Create* and *Update floor |
| | plan* messages. |
| | |
| | - Changed *Create* and *Update |
| | floor plan* messages to |
| | return all floor plan fields. |
| | |
| | - Added coordinate conversion |
| | related data to *Create* and |
| | *Update floor plan* messages. |
| | |
| | - Changed *network* *id* to |
| | number in *Create*, *Update |
| | and Delete network*. |
| | |
| | - Removed *pixel\_location\_x* |
| | and *pixel\_location\_y* from |
| | *Set node metadata* message. |
| | |
| | - Added *remote\_api\_response* |
| | to Influx measurements. |
| | |
| | - Split *analytics\_packet* |
| | Influx measurement's |
| | *travel\_time\_ms* column to |
| | *travel\_time\_ms\_qos0* and |
| | *travel\_time\_ms\_qos1*. |
+-----------------------------------+-----------------------------------+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should be always visible as it is easy reference for what has changed in the API

- [Update building](#update-building)
- [Delete building](#delete-building)
- [Get building's floor plans](#get-buildings-floor-plans)
- [Create floor plan](#create-floor-plan)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in same level as the other floor plan messages

- [Basic data flow and real time situation data](#basic-data-flow-and-real-time-situation-data)
- [Basic data flow to get continuous data](#basic-data-flow-to-get-continuous-data)
- [Real time situation data](#real-time-situation-data)
- [Coordinate conversions](#coordinate-conversions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be "Introduction" chapter right after the main one

| Load scratchpad \* | 1075 | Administrator |
| Get components information | 1081 | All |

\* Message will be documented later (add link instead)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"(add link instead)" should not be in the document

Comment on lines +728 to +729
mapping between WGS84 and pixel coordinates. For more information please
see chapter 9.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference not working as chapters do not have numbers.

Comment on lines +837 to +838
mapping between WGS84 and pixel coordinates. For more information please
see chapter 9.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference not working as chapters do not have numbers.

Comment on lines +980 to +981
mapping between WGS84 and pixel coordinates. For more information please
see chapter 9.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference not working as chapters do not have numbers.

### Get floor plan image data

The method can be used to fetch floor plan image or thumbnail data. The
image binary data is encoded using Base64 (RFC 3548) encoding.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have a link to the RFC?

Comment on lines +1989 to +1995
| Path | Data |
|---------------------------------- | ----------------|
| Message -\> rtsituation\_metadata | cluster\_no |
| | |
| | cluster\_size |
| | |
| | node\_count |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look good in the rendered version

same credentials used to login to authentication service can be used
also to access the database.

The "wirepas*"* database contains several *measurements* (Influx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be star after wirepas word

@PFigs PFigs removed this from the v1.3.0 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apis/wnt Issues related to wnt public api documentation Issues related to documentation of the package and repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants