Updating the protobuf messages to handle request on the gateway status #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Gateways status request and response protobuf messages. This can be used in the case where the mqtt broker does not support retained message and we would like to know the status of the gateways as soon as possible. The concerned topics in the mqtt broker will be : gw-request/get_gw_status gw-response/get_gw_status/<gw-id>/<sink-id>
leppaott
reviewed
Feb 8, 2023
|
|
||
| - **Request:** | ||
|
|
||
| > **topic:** gw-request/get_gw_status |
There was a problem hiding this comment.
Seems to trigger for all gateways.
There was a problem hiding this comment.
Yes, exactly, the goal of this new message was to request the status of all gateways to know which ones are online. Therefore, gw-id is not present in the topic.
leppaott
reviewed
Feb 8, 2023
|
|
||
| - **Response:** | ||
|
|
||
| > **topics:** gw-response/get_gw_status/*\<gw-id\>/\<sink-id\>* |
There was a problem hiding this comment.
You are right sink-id is not used and should be removed from the readme
leppaott
reviewed
Feb 8, 2023
| @@ -538,6 +557,8 @@ definition) | |||
| gw-response/otap_process_scratchpad/<gw-id>/<sink-id> | |||
|
|
|||
| gw-response/otap_set_target_scratchpad/<gw-id>/<sink-id> | |||
|
|
|||
| gw-response/get_gw_status/<gw-id>/<sink-id> | |||
There was a problem hiding this comment.
Sink-id not on https://github.com/wirepas/gateway/pull/237/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Gateways status request and response protobuf messages. This can be used in the case where the mqtt broker does not support retained message and we would like to know the status of the gateways as soon as possible.
The concerned topics in the mqtt broker would be:
gw-request/get_gw_status
gw-response/get_gw_status//