Fix proxyUrlPrefixToRemove property not being applied #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seDefinition, also conditionally return builder of ProxyResponseDefinitionBuilder if proxyBaseUrl is set
|
Fixes #1783 |
|
Thanks |
|
Thank you for merging @tomakehurst. Do you happen to know when the next release will be? |
|
I'm going to attempt it tomorrow if I can find time to merge a couple of other fixes first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxyUrlPrefixToRemove property wasn not being properly applied during runtime. It was not being persisted through the ResponseDefinitionBuilder as it was being stored as a (not static) local variable in a static class.
Also it will now conditionally return builder of ProxyResponseDefinitionBuilder if proxyBaseUrl is set