Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: response header not reflecting correct version of http #1689 #1890

Merged
merged 5 commits into from
Jun 6, 2022
Merged

Bugfix: response header not reflecting correct version of http #1689 #1890

merged 5 commits into from
Jun 6, 2022
+111 −34

Conversation

SaiPoojithaDubba
Copy link
Contributor

link to the issue: #1689

@SaiPoojithaDubba SaiPoojithaDubba changed the title Bugfix: response header notreflecting correct version of http #1689 Bugfix: response header not reflecting correct version of http #1689 Jun 2, 2022
tomakehurst
tomakehurst requested changes Jun 2, 2022
View reviewed changes
Copy link
Member

@tomakehurst tomakehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start and I think only one change is needed, which is to move Response.setProtocol() to Response.Builder.protocol() so that Response remains immutable.

@SaiPoojithaDubba
Copy link
Contributor Author

This is a good start and I think only one change is needed, which is to move Response.setProtocol() to Response.Builder.protocol() so that Response remains immutable.

Change committed!

@tomakehurst tomakehurst merged commit 90145f9 into wiremock:master Jun 6, 2022
@tomakehurst
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomakehurst tomakehurst tomakehurst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SaiPoojithaDubba @tomakehurst