Fix like creating complete response definition #1830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomakehurst
reviewed
Apr 6, 2022
| @@ -66,7 +67,13 @@ public static ResponseDefinitionBuilder like(ResponseDefinition responseDefiniti | |||
| ? Parameters.from(responseDefinition.getTransformerParameters()) | |||
| : Parameters.empty(); | |||
| builder.wasConfigured = responseDefinition.isFromConfiguredStub(); | |||
| return builder; | |||
|
|
|||
| ProxyResponseDefinitionBuilder proxyResponseDefinitionBuilder = new ProxyResponseDefinitionBuilder(builder); | |||
There was a problem hiding this comment.
I think we should do this conditionally, in order to maintain the same behaviour when building from scratch, so e.g.
if (builder.proxyBaseUrl != null) {
// Construct the ProxyResponseDefinitionBuilder
}
// Otherwise keep the builder as-is and return it.
|
Fixed in 9aad878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1783.
Changed the test of
liketo use the main object instead of the builder so that it's more resilient. Added changes to fix the missing recently added properties.Should fix the aforementioned issue and an issue I was having while trying to use
like.