Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxyUrlPrefixToRemove with ResponseTemplateTransformer (#1783) #1784

Closed
wants to merge 1 commit into from
Closed

Fix proxyUrlPrefixToRemove with ResponseTemplateTransformer (#1783) #1784

wants to merge 1 commit into from

Conversation

andrena-eike-kohnert
Copy link

Fixes #1783

@Delfic
Copy link

Delfic commented Mar 4, 2022

Hey 👋
Wouldn't a better fix be to change the ResponseDefinitionBuilder.like method to include the "missing" fields of ResponseDefinition?
They're handled by ProxyResponseDefinitionBuilder but that one doesn't have a like method 🤔

We had a similar issue and fixing the like seems to be a more broad fix.

@tomakehurst
Copy link
Member

Fixed in 9aad878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using Proxying with the ResponseTemplateTransformer the setting proxyUrlPrefixToRemove is ignored
3 participants
@andrena-eike-kohnert @Delfic @tomakehurst