Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump jasmine-core from 3.2.1 to 3.3.0 #4990

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Oct 26, 2018

Bumps jasmine-core from 3.2.1 to 3.3.0.

Release notes

Sourced from jasmine-core's releases.

3.3.0

Please see the release notes

Commits
  • b3ccd43 Bump version to 3.3.0
  • 5524207 Add api docs for .not and .withContext
  • 1b5e0c0 Merge branch 'expect-context'
  • 2d303a6 Merge common async/sync expectation stuff
  • 1e47dcf Pull async matchers out to their own functions
  • ba1e8f8 Implement withContext for async expectations too
  • a91db0d more rejected to -> rejected with
  • 1d13003 Merge branch 'master' into expect-context
  • e6a60a7 Merge branch 'codymikol-toBeRejectedWith'
  • fe042fd Use toBeRejectedWith instead of toBeRejectedTo
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@gregor
Copy link
Contributor

gregor commented Oct 30, 2018

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/jasmine-core-3.3.0 branch from 227fac7 to 4724904 Compare October 30, 2018 10:00
@bennycode
Copy link
Contributor

With Karma 3 random test execution is turned on by default. For our tests we need to turn it off. We are doing this in our karma.conf.js file:

    client: {
      jasmine: {
        random: false,
      }
    },

Unfortunately, this causes an error with Jasmine 3.3: karma-runner/karma-jasmine#221 (comment)

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/jasmine-core-3.3.0 branch from 4724904 to d18c437 Compare November 6, 2018 10:43
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/jasmine-core-3.3.0 branch from d18c437 to 7350dc9 Compare November 15, 2018 15:11
Bumps [jasmine-core](https://github.com/jasmine/jasmine) from 3.2.1 to 3.3.0.
- [Release notes](https://github.com/jasmine/jasmine/releases)
- [Changelog](https://github.com/jasmine/jasmine/blob/master/RELEASE.md)
- [Commits](jasmine/jasmine@v3.2.1...v3.3.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/jasmine-core-3.3.0 branch from 7350dc9 to 99ac66c Compare November 29, 2018 11:24
@bennycode
Copy link
Contributor

Will postpone the update to Jasmine 3.3.

@bennycode bennycode closed this Nov 29, 2018
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/jasmine-core-3.3.0 branch November 29, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants