New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runfix: check if IndexDB enabled in FireFox and extend the message in "Unsupported browser" page WPB-8820 #17350
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #17350 +/- ##
==========================================
- Coverage 46.09% 46.08% -0.01%
==========================================
Files 753 753
Lines 24725 24728 +3
Branches 5667 5668 +1
==========================================
- Hits 11397 11396 -1
- Misses 11898 11903 +5
+ Partials 1430 1429 -1 |
904a916
to
0d2dc5a
Compare
bb1f1fb
to
f6bb62d
Compare
f6bb62d
to
294b2ac
Compare
src/page/unsupported.ejs
Outdated
@@ -130,24 +134,25 @@ | |||
</header> | |||
<main style="flex: 1 1 0; padding-left: 8px; width: 100%;"> | |||
<div class="textContent"> | |||
<h2 data-uie-name="element-unsupported-headline">This browser is not supported.</h2> | |||
<h2 data-uie-name="element-unsupported-headline">Wire doesn't support this browser.</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should all be new translation strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a separate ticket for localization of the strings in the "Unsupported browser" page, we agreed with Tom and Sascha to implement it hardcoded EN for now and think about configuring the link URL and translation later.
Since this one should be the simplest plain HTML that can be shown in any oldest browser possible and it has no scripts at all, it might be really difficult to implement the usage of intl
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://wearezeta.atlassian.net/browse/WPB-9005 - the translation ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the translations please and lets see if we can come up with a better solution than console log
1ac7778
to
9d624c9
Compare
Message in "Unsupported browser" includes settings for cookies and IndexDB;
Remove unused translations;
f74a859
to
63b4b49
Compare
Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>
Quality Gate passedIssues Measures |
Description
- Message in "Unsupported browser" includes settings for cookies and IndexDB;Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers