Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New navigation system #16785

Open
wants to merge 46 commits into
base: dev
Choose a base branch
from
Open

feat: New navigation system #16785

wants to merge 46 commits into from

Conversation

thisisamir98
Copy link
Contributor

@thisisamir98 thisisamir98 commented Feb 8, 2024

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 45.94%. Comparing base (80665cd) to head (22d9b92).
Report is 10 commits behind head on dev.

❗ Current head 22d9b92 differs from pull request most recent head 7189d27. Consider uploading reports for the commit 7189d27 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16785      +/-   ##
==========================================
- Coverage   46.08%   45.94%   -0.14%     
==========================================
  Files         746      749       +3     
  Lines       24520    24516       -4     
  Branches     5611     5599      -12     
==========================================
- Hits        11300    11265      -35     
- Misses      11791    11819      +28     
- Partials     1429     1432       +3     

thisisamir98 and others added 4 commits February 29, 2024 18:08
* feat: Add searchbar to top of conversation list (WPB-5949)

* bump ui kit

* update icon

* chore: add server engine version

* fix search logic

* only show in recent tab

* style and copy

* adjust search input styles to new design

* migrate styles to separate file

* shorten syntax

---------

Co-authored-by: Timothy Le Bon <tlebon@gmail.com>
* feat: initial sidebar change (WPB-5944)

* feat: migrate contacts to connect

* Update src/style/list/conversations.less

Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>

* Update src/style/list/conversations.less

Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>

---------

Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>
* feat: add badges to new navigation sidebar

* feat: update copy

* remove label

* remove extra code
* feat: add favorites tab (WPB-5946)

* feat: update favorites icon

* feat: add new groups tab

* feat: add direct conversations

* fix: correct badge for directs

* reset filter on view switch
thisisamir98 and others added 10 commits March 4, 2024 13:42
…16967)

* feat: Add searchbar to top of conversation list (WPB-5949) (#16676)

* feat: Add searchbar to top of conversation list (WPB-5949)

* bump ui kit

* update icon

* chore: add server engine version

* fix search logic

* only show in recent tab

* style and copy

* adjust search input styles to new design

* migrate styles to separate file

* shorten syntax

---------

Co-authored-by: Timothy Le Bon <tlebon@gmail.com>

* feat: Add sidebar with existing options (WPB-5944) (#16784)

* feat: initial sidebar change (WPB-5944)

* feat: migrate contacts to connect

* Update src/style/list/conversations.less

Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>

* Update src/style/list/conversations.less

Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>

---------

Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>

* feat: add badges to new navigation sidebar (WPB-6651) (#16849)

* feat: add badges to new navigation sidebar

* feat: update copy

* remove label

* remove extra code

* feat: add favorites, groups & directs tabs (WPB-5946) (#16861)

* feat: add favorites tab (WPB-5946)

* feat: update favorites icon

* feat: add new groups tab

* feat: add direct conversations

* fix: correct badge for directs

* reset filter on view switch

* feat: add search to groups, favorites & directs sidebar tabs

* refactor: remove extra folders from folders view

* refactor: rename ConversationViewStyle to SidebarTabs

* refactor: rename viewStyle to sidebarTab

* refactor: rename view style to current tab

* feat: move connect and archives to new navigation system

* fix: show current active sidebar tabs

* fix: bring back prefrences

* refactor use or

* refactor: remove commented code

* refactor: reuse isFolderView

* Update src/script/page/LeftSidebar/panels/Conversations/Conversations.tsx

Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com>

* refactor: use includes

* refactor: remove extra white space

---------

Co-authored-by: Timothy Le Bon <tlebon@gmail.com>
Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com>
* runfix: address new navigation styling in dark mode (WPB-6811)

* remove unused css class

* use themed input color for labels
* feat: basic new preferences

* fix header

* fix: show custom folders

* finalize animation removal

* feat: remove settings icon from sidebar tabs

* feat: update copies

* bring back line breaks
* feat: user details in new nav structure

* remove header from left sidebar

* CR fixes
* feat: Empty state for conversations

* remove unecessary code
przemvs and others added 4 commits March 28, 2024 12:12
* feat: sidebar toggle

* basic hover

* handler tweaks

* move button to bottom

* update background color

* feat: handle accesiblity error
* feat: add support for folders

* fix style

* feat: merge filters

* refactor: merge current folder logic

* refactor: use find instead of filter
* runfix: address darkmode color values

* assign css variable for gray text
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 45.94%. Comparing base (019e347) to head (22d9b92).
Report is 96 commits behind head on dev.

Current head 22d9b92 differs from pull request most recent head e787673

Please upload reports for the commit e787673 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16785      +/-   ##
==========================================
- Coverage   46.10%   45.94%   -0.16%     
==========================================
  Files         751      749       -2     
  Lines       24750    24516     -234     
  Branches     5661     5599      -62     
==========================================
- Hits        11412    11265     -147     
+ Misses      11906    11819      -87     
  Partials     1432     1432              

przemvs and others added 24 commits April 5, 2024 13:04
* runfix: prevent loading of unreachable users (WPB-7377)

* show conv with unavailable user if there's messages
* fix: update header height

* update conversationheader min-height

* remove unecessary code
* feat: update collpasible sidebar ux

* fix: hide overflow

* fix: remove hard coded long display name

* feat: make sidebar open by default

* refactor: use isSideBarOpen directly

* refactor: remove extra commented code

* refactor: use short syntax for padding
* fix: do not show sidebar in full screen call

* feat: add folders empty state

* feat: remove unread indicator from folder tab

* feat: update empty link

* refactor: get rid of dangerouslySetInnerHTML
* feat: support for folders in collapsed sidebar

* runfix: do not open folders when switching from settings to other tabs

* runfix: auto close sidebar on md breakpoint

* Update src/script/page/LeftSidebar/panels/Conversations/Conversations.tsx

Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>

---------

Co-authored-by: Thomas Belin <thomasbelin4@gmail.com>
* feat: left sidebar improvements

* remove unecessary code
* feat: User Availability state

* hide availability state in preferences and user details in right sidebar

* availability user state

* replace deprecated isTeamMember

* code cleanup

* revert data-uie-name

* revert data-uie-name
* feat: Preferences header background

* update cr suggestions
* feat: new badge without number

* handle folders

* feat: auto switch to recent tabs when all conversations of folder are deleted

* feat: auto remove conversation from favorites

* feat: do not open folder tab on favoriting conversation, open favorites tab

* Update src/script/conversation/ConversationLabelRepository.ts

Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>

---------

Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>
* runfix: address responsivness of new navigation v2

* prevent sidebar from loosing width

* assign correct overlay behavior at smaller screen width

* add style file
…17409)

* runfix: adress responsivness of the preferences sections (WPB-7214)

* add object css file for preferences style

* implement fallback viewport media qqueries

* assign flexible width to elements inside preferences
* feat: remove create group & create gust room from connect tab

* remove unused props
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
43 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants