Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search visibility (#SQSERVICES-1442) #13402

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

PatrykBuniX
Copy link
Contributor

@PatrykBuniX PatrykBuniX commented Jul 29, 2022

StorySQSERVICES-1442 [Web] Search visibility rules


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Search visibility feature:

  • feature's status/config change notification on app's load
  • current feature's config state modal opens on info button click

(it's draft PR because it's blocked by BE implementation)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

src/script/components/UserSearchInputInfoButton.tsx Outdated Show resolved Hide resolved
src/script/team/TeamRepository.ts Outdated Show resolved Hide resolved
src/script/team/TeamRepository.ts Outdated Show resolved Hide resolved
src/script/team/TeamRepository.ts Outdated Show resolved Hide resolved
src/script/team/TeamSearchVisibilitySetting.ts Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants