Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flickering in message list due to paging (AR-2848) #1235

Merged
merged 1 commit into from Dec 15, 2022

Conversation

vitorhugods
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. Open a conversation with dozens of messages
  2. Scroll up some 40 messages
  3. Receive a new message

What is happening

The app scrolls down to somewhere random, and we need to scroll back up to see the older messages.

Causes

Our QueryPagingSource was implemented in a hacky way, using an old and buggy implementation.

Solutions

Rely on the newest version of SqlDelight to do it, which works well and is properly tested.

Link to the actual implementation here.

Testing

How to Test

Reproduce same steps described in the issue.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022

Unit Test Results

    2 files   -    291      2 suites   - 291   1m 30s ⏱️ +47s
220 tests  - 1 196  219 ✔️  - 1 156  1 💤  - 40  0 ±0 

Results for commit 1b12553. ± Comparison against base commit 108ea84.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@gongracr gongracr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 🍫

@vitorhugods vitorhugods merged commit 992b2e7 into develop Dec 15, 2022
@vitorhugods vitorhugods deleted the fix/message_list_flickering_due_to_pagination branch December 15, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants