Fix android null pointer #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typfel
approved these changes
Sep 5, 2022
beltram
force-pushed
the
fix/android-build
branch
from
ed36971
to
185b65d
Compare
|
Should we open an issue on https://github.com/RustCrypto/hashes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Running core-crypto on Android fails because of a null pointer error in the sha2 crate. The regression was introduced by this PR which narrows down the supported architectures, excluding Android ones. It is likely the sha2-asm is supported on more targets than it claims.
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.