Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer dependency updates for Laravel 9 support #172

Conversation

tschallacka
Copy link

@tschallacka tschallacka commented May 13, 2021

Pulled current develop branch into wip/1.2 to bring wip/1.2 up to date with the current status

Modified composer.json.

Referenced storm/wip/1.2 for storm dependency
Referenced wip/1.2 for the modules backend, cms, and system. This needs to be altered when work in progress becomes final.
Altered Laravel dependency to ~9.0
Set minimum PHP version to 7.4

Modified modules/backend/composer.json, modules/cms/composer.json, modules/system/composer.json

Altered Laravel dependency to ~9.0
Set minimum PHP version to 7.4

Updating the WIP branches as discussed here #148 (comment) would be greatly appreciated :-)

@LukeTowers LukeTowers changed the base branch from wip/1.2 to develop May 14, 2021 15:18
@LukeTowers LukeTowers changed the base branch from develop to wip/1.2 May 14, 2021 15:19
@LukeTowers
Copy link
Member

@tschallacka 9.0 isn't out yet so we'll need to target the same version as the Storm library in 1.2, and then once 9.0 is out and we're ready to release 1.2 we can switch it back to 9.0

@tschallacka
Copy link
Author

@LukeTowers My bad, fixed now with the same version that's in the storm library.

@bennothommo bennothommo marked this pull request as draft May 16, 2021 00:53
@bennothommo bennothommo changed the title Composer json updates to laravel 9 Composer dependency updates for Laravel 9 support May 16, 2021
@github-actions
Copy link

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@LukeTowers
Copy link
Member

@tschallacka is Laravel 9 going to be requiring minimum of PHP 8 now?

@LukeTowers
Copy link
Member

@tschallacka could you bump it in the winter & storm repo PRs?

@tschallacka
Copy link
Author

tschallacka commented Jul 17, 2021

@LukeTowers I assume you mean the upgrade to nine branch, thats already done wintercms/storm@e59b50a#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R46

@tschallacka
Copy link
Author

Laravel has pushed its newest major release to 2022. https://laravel-news.com/laravel-9

Php8 & symfony 6

Maybe rename/move these commits to a laravel 9 branch so winter can push out an minor update in the long wait?

@LukeTowers
Copy link
Member

@tschallacka we still are pushing minor updates, 1.2 is not blocking 1.1.*, our free time is doing that 😉

@LukeTowers LukeTowers marked this pull request as ready for review December 10, 2021 03:45
@LukeTowers LukeTowers closed this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants