Support Laravel 9 LTS #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
Co-authored-by: Luke Towers <github@luketowers.ca>
Co-authored-by: Luke Towers <github@luketowers.ca>
Code analysis for Laravel 9 branch
Temporary fix while waiting for twigphp/Twig#3719 to be merged.
This reverts commit f3b0aa9.
Restores previous default value for BlockBuilder placeholder/get methods (changed in 1a46e9e which caused issues as the `placeholderFunction` method in the CMS module was checking for null, not an empty string. Technically speaking a block that doesn't exist with no default value provided should return null, so the original default parameter values were correct.
LukeTowers
commented
Jul 12, 2022
LukeTowers
commented
Jul 13, 2022
Fixes issue introduced in 32df10c that caused double encoded URLs present in a URL's path (double encoded to survive Laravel's router that decodes path segments before routing) to be decoded during UrlGenerator actions which would break them as the output would no longer be double encoded as was specifically provided to the input. The above commit broke the ImageResizer encoded URLs in wintercms/winter
|
NOTE v1.1.9 will need to be reviewed and made live before this PR is merged into develop. |
* develop: Apply fix from 1.0 Add test case for trimStringAttributes flag Make string attribute value auto-trimming optional (#97) # Conflicts: # src/Database/Attach/File.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See wintercms/winter#148 for more information.