Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorial): Integrate a full tutorial #185

Merged
merged 12 commits into from
Feb 20, 2023
Merged

docs(tutorial): Integrate a full tutorial #185

merged 12 commits into from
Feb 20, 2023

Conversation

epage
Copy link
Collaborator

@epage epage commented Feb 20, 2023

This started with rust-bakery/nom#1525 and

  • Updated for API improvements
  • Tried to build on previous chapters to provide a more cohesive experience
  • Integrated it into rustdoc

Fixes #101

@coveralls
Copy link

coveralls commented Feb 20, 2023

Pull Request Test Coverage Report for Build 4227314282

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 52.401%

Files with Coverage Reduction New Missed Lines %
src/bytes/complete.rs 1 76.97%
src/character/complete.rs 1 81.45%
Totals Coverage Status
Change from base Build 4225098223: -0.06%
Covered Lines: 1735
Relevant Lines: 3311

💛 - Coveralls

This is a part of the "old tutorial" that is worth carrying forward.
@epage epage merged commit a9979b0 into winnow-rs:main Feb 20, 2023
@epage epage deleted the tut branch February 20, 2023 22:06
@tfpk
Copy link
Contributor

tfpk commented Mar 1, 2023

Excited to see this being useful; let me know if there's any other changes I can help with (have been waiting for it to be merged into nom, but until then if I can help here I'd be happy to).

@epage
Copy link
Collaborator Author

epage commented Mar 1, 2023

Thank you for originally creating it!

I can't think of anything more at the moment. I did a pass to make the example build on itself and added the app integration at the end. At this point it is seeing where people get confused to see what could be made better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull in a full tutorial
3 participants