Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add staking pool deploy script #352

Merged
merged 4 commits into from Jul 6, 2022
Merged

feat: add staking pool deploy script #352

merged 4 commits into from Jul 6, 2022

Conversation

aodhgan
Copy link
Contributor

@aodhgan aodhgan commented Jul 4, 2022

Purpose for this PR

closes #338

@aodhgan aodhgan requested a review from a team as a code owner July 4, 2022 01:40
@aodhgan aodhgan mentioned this pull request Jul 4, 2022
Closed
CjHare
CjHare reviewed Jul 4, 2022
View reviewed changes
Copy link
Contributor

@CjHare CjHare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: where is the update to the docs?

The readme links to two deploy docs, a local and remote

@aodhgan aodhgan marked this pull request as draft July 5, 2022 01:26
@aodhgan
Copy link
Contributor Author

aodhgan commented Jul 5, 2022

todo: update deploy_local.md

@aodhgan aodhgan marked this pull request as ready for review July 5, 2022 21:46
CjHare
CjHare approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@CjHare CjHare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comment / TODOs and it looks good 🙂

scripts/verify/create-staking-pool.ts Outdated Show resolved Hide resolved
@aodhgan aodhgan merged commit 4277188 into main Jul 6, 2022
@aodhgan aodhgan deleted the feat/dp-sp branch July 6, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CjHare CjHare CjHare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Deploy scripts for Staking
2 participants
@aodhgan @CjHare