Update HTTP gem version dependency #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version currently in use has an incompatibility with Ruby 2.7: httprb/http#582 The earliest version with a fix for this is 4.3.0 (as per noted here: elastic/apm-agent-ruby#665 (comment))
|
@wilsonsilva: More Ruby 2.7 changes 🎉 |
|
FYI, this is where I identified the error and debugged it right up to the use of HTTP gem.
|
|
Lovely, thank you! Are you using this gem in production? If so, I can put a bit more effort onto it and keep it up to date with Loqate's API. |
|
Thank you @wilsonsilva ! Yes, we are making use of it in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version currently in use has an incompatibility with Ruby 2.7: httprb/http#582
The earliest version with a fix for this is 4.3.0 (as per noted here:
elastic/apm-agent-ruby#665 (comment))