This repository has been archived by the owner on Mar 30, 2019. It is now read-only.
wip - setup event bus to listen for touches. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willrax
changed the title
On mobile browsers hover is replaced with touch to trigger the tooltip. This causes the tool tip to not close when you touch anywhere else on the document. This adds an event bus to listen for touches on the document and then resets the visible value to null. We change from false to null here, because we don’t want to override any of the user overrides. Eg; if you as a developer manually control the visibility of a tooltip then we won’t try to automatically open or close it.
willrax
force-pushed
the
close-on-touch
branch
from
effd02f
to
45a3d8a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile browsers hover is replaced with touch to trigger the tooltip. This causes the tool tip to not close when you touch anywhere else on the document.
This adds an event bus to listen for touches on the document and then resets the visible value to null.
We change from false to null here, because we don’t want to override any of the user overrides. Eg; if you as a developer manually control the visibility of a tooltip then we won’t try to automatically open or close it.