[WFMP-175] Add property to skip the deployment in the package goal. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfdenise
approved these changes
Oct 6, 2022
jamezp
reviewed
Oct 6, 2022
plugin/src/main/java/org/wildfly/plugin/provision/PackageServerMojo.java
Outdated
Show resolved
Hide resolved
jamezp
reviewed
Oct 6, 2022
plugin/src/main/java/org/wildfly/plugin/provision/PackageServerMojo.java
Outdated
Show resolved
Hide resolved
If wildfly.package.deployment.skip is true, the user deployment will not be deployed in the provisioned server. JIRA: https://issues.redhat.com/browse/WFMP-175 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil
force-pushed
the
WFMP-175_wildfly.package.deployment.skip
branch
from
526a585
to
226b5e1
Compare
jamezp
reviewed
Oct 6, 2022
| @@ -160,6 +160,12 @@ public class PackageServerMojo extends AbstractProvisionServerMojo { | |||
| @Parameter(defaultValue = "false", property = PropertyNames.SKIP_PACKAGE) | |||
| private boolean skip; | |||
|
|
|||
| /** | |||
| * Skip deploying the deployment after the server is provisioned ({@code false} by default). | |||
There was a problem hiding this comment.
I don't think there is any reason to change this, but just as an FYI the default will automatically be added in the generated site. For example https://docs.wildfly.org/wildfly-maven-plugin/package-mojo.html#offlineProvisioning
jamezp
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If wildfly.package.deployment.skip is true, the user deployment will not be deployed in the provisioned server.
JIRA: https://issues.redhat.com/browse/WFMP-175
Signed-off-by: Jeff Mesnil jmesnil@redhat.com