[WFCORE-5859] Add Filesystem integrity support #5048

Ashpan · 2022-04-06T18:08:32Z

Jira: https://issues.redhat.com/browse/WFCORE-5859
To pass CI, this will require an Elytron upgrade.

Analysis document: wildfly/wildfly-proposals#462
Requires: https://issues.redhat.com/browse/ELY-2320
Elytron PR with tests: wildfly-security/wildfly-elytron#1709
WildFly PR with tests and documentation updates: wildfly/wildfly#15411

wildfly-ci · 2022-04-06T18:12:25Z

Core - Full Integration Build 11522 outcome was FAILURE using a merge of 2d78d57
Summary: Compilation error: Compiler (new) Build time: 00:02:03

wildfly-ci · 2022-04-06T18:12:53Z

Core - Full Integration Build 11390 outcome was FAILURE using a merge of 2d78d57
Summary: Compilation error: Compiler (new) Build time: 00:02:30

luck3y · 2022-04-07T15:38:24Z

/retest

wildfly-ci · 2022-04-07T15:41:54Z

Core - Full Integration Build 11295 outcome was FAILURE using a merge of 2d78d57
Summary: Compilation error: Compiler (new) Build time: 00:01:35

wildfly-ci · 2022-04-07T15:42:31Z

Core - Full Integration Build 11428 outcome was FAILURE using a merge of 2d78d57
Summary: Compilation error: Compiler (new) Build time: 00:02:11

luck3y · 2022-04-11T16:56:52Z

/retest

wildfly-ci · 2022-04-11T17:00:00Z

Core - Full Integration Build 11317 outcome was FAILURE using a merge of 2d78d57
Summary: Compilation error: Compiler Build time: 00:01:36

wildfly-ci · 2022-04-11T17:00:39Z

Core - Full Integration Build 11456 outcome was FAILURE using a merge of 2d78d57
Summary: Compilation error: Compiler Build time: 00:02:17

Skyllarr · 2022-04-12T14:05:37Z

elytron/pom.xml

@@ -318,6 +318,10 @@
                    <groupId>org.apache.commons</groupId>
                    <artifactId>commons-lang3</artifactId>
                </exclusion>
+                <exclusion>


@Ashpan Is this exclusion needed?

Skyllarr · 2022-04-12T14:47:06Z

elytron/src/main/java/org/wildfly/extension/elytron/FileSystemRealmDefinition.java

+            try {
+                return keyStoreService.resolveKeyPassword(credentialSourceSupplierInjector.getOptionalValue());
+            } catch (Exception e) {
+                throw new RuntimeException(e);


This could be added to the ElytronMessages

Skyllarr · 2022-04-12T14:50:53Z

pom.xml

@@ -1963,6 +1973,12 @@
                <groupId>org.wildfly.security</groupId>
                <artifactId>wildfly-elytron-realm</artifactId>
                <version>${version.org.wildfly.security.elytron}</version>
+                <exclusions>


@Ashpan Why was this and above exclusions added?

OndrejKotek · 2022-04-21T14:08:48Z

elytron/src/main/java/org/wildfly/extension/elytron/FileSystemRealmDefinition.java

+                                        keyStoreService = getModifiableKeyStoreService(keyStoreServiceRegistry, keyStoreName);
+                                        char[] keyPassword = getKeyStorePassword((KeyStoreService) keyStoreService);
+                                        privateKey = (PrivateKey) keyStore.getKey(keyPairAlias, keyPassword);
+                                        publicKey = keyStore.getCertificate(keyPairAlias).getPublicKey();


The can be no alias of the given name in the given store. (The same issue we had in case of the encryption feature).

[standalone@localhost:9990 /] /subsystem=elytron/filesystem-realm=fs1:add(path=fs1,key-store=applicationKS,key-store-alias=alias1) { "outcome" => "failed", "failure-description" => {"WFLYCTL0080: Failed services" => {"org.wildfly.security.modifiable-security-realm.fs1" => "Failed to start service Caused by: java.lang.NullPointerException"}}, "rolled-back" => true }

16:02:43,095 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-1) MSC000001: Failed to start service org.wildfly.security.modifiable-security-realm.fs1: org.jboss.msc.service.StartException in service org.wildfly.security.modifiable-security-realm.fs1: Failed to start service at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1731) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1559) at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.lang.NullPointerException at org.wildfly.extension.elytron@19.0.0.Beta7-SNAPSHOT//org.wildfly.extension.elytron.FileSystemRealmDefinition$RealmAddHandler$1.get(FileSystemRealmDefinition.java:323) at org.wildfly.extension.elytron@19.0.0.Beta7-SNAPSHOT//org.wildfly.extension.elytron.FileSystemRealmDefinition$RealmAddHandler$1.get(FileSystemRealmDefinition.java:299) at org.wildfly.extension.elytron@19.0.0.Beta7-SNAPSHOT//org.wildfly.extension.elytron.TrivialService.start(TrivialService.java:61) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1739) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1701) ... 6 more 16:02:43,099 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 2) WFLYCTL0013: Operation ("add") failed - address: ([ ("subsystem" => "elytron"), ("filesystem-realm" => "fs1") ]) - failure description: {"WFLYCTL0080: Failed services" => {"org.wildfly.security.modifiable-security-realm.fs1" => "Failed to start service Caused by: java.lang.NullPointerException"}} 16:02:43,100 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 2) WFLYCTL0013: Operation ("add") failed - address: ([ ("subsystem" => "elytron"), ("filesystem-realm" => "fs1") ]) - failure description: {"WFLYCTL0080: Failed services" => {"org.wildfly.security.modifiable-security-realm.fs1" => "Failed to start service Caused by: java.lang.NullPointerException"}}

OndrejKotek · 2022-04-22T11:24:01Z

elytron/src/main/java/org/wildfly/extension/elytron/FileSystemRealmDefinition.java

+            TrivialService<FileSystemSecurityRealm> filesystemService = (TrivialService<FileSystemSecurityRealm>) getFileSystemService(context);
+            FileSystemSecurityRealm fileSystemRealm = filesystemService.getValue();
+            try {
+                fileSystemRealm.updateRealmKeyPair();


What about a check that there is a key-pair to be used?

[standalone@localhost:9990 /] /subsystem=elytron/filesystem-realm=fsRealm:update-key-pair() { "outcome" => "failed", "failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.NullPointerException: signingKey cannot be null", "rolled-back" => true }

13:14:46,650 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("update-key-pair") failed - address: ([ ("subsystem" => "elytron"), ("filesystem-realm" => "fsRealm") ]): java.lang.NullPointerException: signingKey cannot be null at java.xml.crypto/javax.xml.crypto.dsig.dom.DOMSignContext.<init>(DOMSignContext.java:74) at org.wildfly.security.elytron-base@1.19.1.CR1-SNAPSHOT//org.wildfly.security.auth.realm.FileSystemSecurityRealm$Identity.createDigitalSignature(FileSystemSecurityRealm.java:1470) at org.wildfly.security.elytron-base@1.19.1.CR1-SNAPSHOT//org.wildfly.security.auth.realm.FileSystemSecurityRealm$Identity.access$400(FileSystemSecurityRealm.java:575) at org.wildfly.security.elytron-base@1.19.1.CR1-SNAPSHOT//org.wildfly.security.auth.realm.FileSystemSecurityRealm.updateRealmKeyPair(FileSystemSecurityRealm.java:568) at org.wildfly.extension.elytron@19.0.0.Beta7-SNAPSHOT//org.wildfly.extension.elytron.FileSystemRealmDefinition$ChangeKeyPairHandler.executeRuntimeStep(FileSystemRealmDefinition.java:229) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.AbstractRuntimeOnlyHandler$1.execute(AbstractRuntimeOnlyHandler.java:59) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:1045) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:777) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:466) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1427) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:449) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.lambda$executeForResponse$0(ModelControllerImpl.java:260) at org.wildfly.security.elytron-base@1.19.1.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:304) at org.wildfly.security.elytron-base@1.19.1.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:270) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.executeForResponse(ModelControllerImpl.java:260) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.executeOperation(ModelControllerImpl.java:254) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:237) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.doExecute(ModelControllerClientOperationHandler.java:241) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:163) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:159) at org.wildfly.security.elytron-base@1.19.1.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:328) at org.wildfly.security.elytron-base@1.19.1.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:285) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:254) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:225) at org.jboss.as.controller@19.0.0.Beta7-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1.execute(ModelControllerClientOperationHandler.java:159) at org.jboss.as.protocol@19.0.0.Beta7-SNAPSHOT//org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$1.doExecute(ManagementRequestContextImpl.java:70) at org.jboss.as.protocol@19.0.0.Beta7-SNAPSHOT//org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$AsyncTaskRunner.run(ManagementRequestContextImpl.java:160) at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads@2.4.0.Final//org.jboss.threads.JBossThread.run(JBossThread.java:513)

fjuma · 2022-04-25T17:37:31Z

elytron/src/main/java/org/wildfly/extension/elytron/ElytronSubsystemTransformers.java

@@ -158,7 +160,11 @@ private static void from15_1(ChainedTransformationDescriptionBuilder chainedBuil
                .setDiscard(DiscardAttributeChecker.UNDEFINED, CREDENTIAL_STORE)
                .setDiscard(DiscardAttributeChecker.UNDEFINED, SECRET_KEY)
                .addRejectCheck(RejectAttributeChecker.DEFINED, CREDENTIAL_STORE)
-                .addRejectCheck(RejectAttributeChecker.DEFINED, SECRET_KEY);
+                .addRejectCheck(RejectAttributeChecker.DEFINED, SECRET_KEY)


We'll need another Elytron subsystem bump. Will let you know once I've submitted a PR for that.

@Ashpan Just FYI, the Elytron subsystem bump is now available here:

#5090

fjuma · 2022-04-25T17:40:08Z

elytron/src/main/java/org/wildfly/extension/elytron/FileSystemRealmDefinition.java

@@ -140,7 +159,27 @@ class FileSystemRealmDefinition extends SimpleResourceDefinition {
                    .setRestartAllServices()
                    .build();

-    static final AttributeDefinition[] ATTRIBUTES = new AttributeDefinition[]{PATH, RELATIVE_TO, LEVELS, ENCODED, HASH_ENCODING, HASH_CHARSET, CREDENTIAL_STORE, SECRET_KEY};
+    static final SimpleAttributeDefinition KEY_STORE =
+            new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.KEY_STORE, ModelType.STRING, false)


Since this attribute is optional, the last constructor parameter should be true.

fjuma · 2022-04-25T17:40:27Z

elytron/src/main/java/org/wildfly/extension/elytron/FileSystemRealmDefinition.java

+    static final SimpleAttributeDefinition KEY_STORE =
+            new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.KEY_STORE, ModelType.STRING, false)
+                    .setAllowExpression(true)
+                    .setRequired(false)


This line should then be removed since we've already specified it is optional from the constructor.

fjuma · 2022-04-25T17:41:08Z

elytron/src/main/java/org/wildfly/extension/elytron/FileSystemRealmDefinition.java

+                    .build();
+
+    static final SimpleAttributeDefinition KEY_STORE_ALIAS =
+            new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.KEY_STORE_ALIAS, ModelType.STRING, false)


The last parameter should be true.

fjuma · 2022-04-25T17:41:20Z

elytron/src/main/java/org/wildfly/extension/elytron/FileSystemRealmDefinition.java

+    static final SimpleAttributeDefinition KEY_STORE_ALIAS =
+            new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.KEY_STORE_ALIAS, ModelType.STRING, false)
+                    .setAllowExpression(true)
+                    .setRequired(false)


This line can be removed.

fjuma · 2022-04-25T17:42:25Z

elytron/src/main/java/org/wildfly/extension/elytron/FileSystemRealmDefinition.java

+        }
+    }
+
+    static class ChangeKeyPairHandler extends ElytronRuntimeOnlyHandler {


Just a minor comment but maybe this could be called UpdateKeyPairHandler instead (just to match the operation name).

fjuma · 2022-04-25T17:56:25Z

elytron/src/main/java/org/wildfly/extension/elytron/FileSystemRealmDefinition.java

+                                    try {
+                                        keyStoreService = getModifiableKeyStoreService(keyStoreServiceRegistry, keyStoreName);
+                                        char[] keyPassword = getKeyStorePassword((KeyStoreService) keyStoreService);
+                                        privateKey = (PrivateKey) keyStore.getKey(keyPairAlias, keyPassword);


Before attempting to get the private key and public key, would be good to check if the alias actually exists in the key store. If not, an appropriate exception should be thrown.

fjuma · 2022-04-25T17:57:46Z

elytron/src/main/java/org/wildfly/extension/elytron/FileSystemRealmDefinition.java

+                                        privateKey = (PrivateKey) keyStore.getKey(keyPairAlias, keyPassword);
+                                        publicKey = keyStore.getCertificate(keyPairAlias).getPublicKey();
+                                        if (privateKey == null ^ publicKey == null) {
+                                           throw ROOT_LOGGER.invalidKeyPair(keyStoreName, keyPairAlias);


It might also be good to have different exception messages depending on whether the private key or public key is null. As an example, you could take a look at what was done here:

https://github.com/wildfly/wildfly-core/blob/main/elytron/src/main/java/org/wildfly/extension/elytron/AdvancedModifiableKeyStoreDecorator.java#L345-L364

fjuma · 2022-04-25T18:00:25Z

elytron/src/main/java/org/wildfly/extension/elytron/KeyStoreServiceUtil.java

+ * @author <a href="mailto:araskar@redhat.com">Ashpan Raskar</a>
+ */
+
+public class KeyStoreServiceUtil {


This shouldn't be public.

fjuma · 2022-04-25T18:01:45Z

elytron/src/main/java/org/wildfly/extension/elytron/RealmParser.java

@@ -108,6 +108,8 @@ class RealmParser {
            .addAttributes(FileSystemRealmDefinition.HASH_CHARSET)
            .addAttributes(FileSystemRealmDefinition.CREDENTIAL_STORE) // new
            .addAttributes(FileSystemRealmDefinition.SECRET_KEY) // new
+            .addAttribute(FileSystemRealmDefinition.KEY_STORE) //new


This will need to be updated once my subsystem bump is ready. A new filesystemRealmParser variable will need to be added.

fjuma · 2022-04-25T18:04:47Z

elytron/src/main/java/org/wildfly/extension/elytron/_private/ElytronSubsystemMessages.java

+    StartException invalidKeyPair(String keyStore, String alias);
+
+    @Message(id = 1213, value = "Unable to update the filesystem realm with the new keystore: %s")
+    OperationFailedException unableToUpdateFilesystemKeystore(@Cause Exception cause, String causeMessage);


Maybe we could update this message to make it more clear, e.g., maybe something like "Unable to update the filesystem realm to make use of the provided key pair for integrity" or something along those lines.

fjuma · 2022-04-25T18:05:43Z

elytron/src/main/resources/org/wildfly/extension/elytron/LocalDescriptions.properties

@@ -888,6 +888,12 @@ elytron.filesystem-realm.hash-encoding=The string format for the password if it
 elytron.filesystem-realm.hash-charset=The character set to use when converting the password string to a byte array.
 elytron.filesystem-realm.credential-store=The reference to the credential store that contains the secret key to encrypt and decrypt the realm.
 elytron.filesystem-realm.secret-key=The alias of the secret key to encrypt and decrypt the realm.
+elytron.filesystem-realm.key-store=The reference to the key store that contains the key pair to perform filesystem integrity checks.


"to perform filesystem integrity checks" -> "to use to verify integrity"

fjuma · 2022-04-25T18:06:38Z

elytron/src/main/resources/org/wildfly/extension/elytron/LocalDescriptions.properties

@@ -888,6 +888,12 @@ elytron.filesystem-realm.hash-encoding=The string format for the password if it
 elytron.filesystem-realm.hash-charset=The character set to use when converting the password string to a byte array.
 elytron.filesystem-realm.credential-store=The reference to the credential store that contains the secret key to encrypt and decrypt the realm.
 elytron.filesystem-realm.secret-key=The alias of the secret key to encrypt and decrypt the realm.
+elytron.filesystem-realm.key-store=The reference to the key store that contains the key pair to perform filesystem integrity checks.
+elytron.filesystem-realm.key-store-alias=The alias of the key store to perform filesystem integrity checks.


"The alias of the key store to perform filesystem integrity checks" -> "The alias that identifies the PrivateKeyEntry within the key store to use to verify integrity"

fjuma · 2022-04-25T18:07:56Z

elytron/src/main/resources/org/wildfly/extension/elytron/LocalDescriptions.properties

+elytron.filesystem-realm.key-store=The reference to the key store that contains the key pair to perform filesystem integrity checks.
+elytron.filesystem-realm.key-store-alias=The alias of the key store to perform filesystem integrity checks.
+# Operations
+elytron.filesystem-realm.update-key-pair=Change the key store associated with the filesystem realm for integrity support.


"the key store" -> "the key pair"

"integrity support" -> "verifying integrity"

fjuma · 2022-04-25T18:08:35Z

elytron/src/main/resources/org/wildfly/extension/elytron/LocalDescriptions.properties

+elytron.filesystem-realm.key-store-alias=The alias of the key store to perform filesystem integrity checks.
+# Operations
+elytron.filesystem-realm.update-key-pair=Change the key store associated with the filesystem realm for integrity support.
+elytron.filesystem-realm.update-key-pair.key-store=Reference to the new keystore to be used in the filesystem realm.


Note keystore is one word here but two words above. Please check what's done elsewhere and then we should use a consistent approach here.

"to be used in the filesystem realm" -> "to be used for verifying integrity"

wildfly-ci · 2022-07-04T14:07:56Z

Core -> WildFly Preview Integration Build 11719 outcome was FAILURE using a merge of c00984c
Summary: Compilation error: Compiler Build time: 00:01:31

wildfly-ci · 2022-07-04T14:07:57Z

Core -> Full Integration Build 11553 outcome was FAILURE using a merge of c00984c
Summary: Compilation error: Compiler Build time: 00:01:33

wildfly-ci · 2022-07-04T17:04:23Z

Core -> Full Integration Build 11554 outcome was FAILURE using a merge of 11674bc
Summary: Compilation error: Compiler (new) Build time: 00:01:01

wildfly-ci · 2022-07-04T17:04:29Z

Core -> WildFly Preview Integration Build 11720 outcome was FAILURE using a merge of 11674bc
Summary: Compilation error: Compiler (new) Build time: 00:01:07

wildfly-ci · 2022-07-04T17:04:51Z

Core -> Full Integration Build 11719 outcome was FAILURE using a merge of 11674bc
Summary: Compilation error: Compiler (new) Build time: 00:01:29

wildfly-ci · 2022-07-26T14:23:21Z

Core -> WildFly Preview Integration Build 11747 outcome was FAILURE using a merge of 0914f8a
Summary: Compilation error: Compiler Build time: 00:01:24

wildfly-ci · 2022-07-26T14:23:44Z

Core -> Full Integration Build 11747 outcome was FAILURE using a merge of 0914f8a
Summary: Compilation error: Compiler Build time: 00:01:46

wildfly-ci · 2022-07-26T14:23:45Z

Core -> Full Integration Build 11579 outcome was FAILURE using a merge of 0914f8a
Summary: Compilation error: Compiler Build time: 00:01:43

wildfly-ci · 2022-07-26T21:23:50Z

Core -> WildFly Preview Integration Build 11749 outcome was FAILURE using a merge of 13e3181
Summary: Compilation error: Compiler Build time: 00:01:53

wildfly-ci · 2022-07-26T21:23:53Z

Core -> Full Integration Build 11581 outcome was FAILURE using a merge of 13e3181
Summary: Compilation error: Compiler Build time: 00:01:56

wildfly-ci · 2022-07-26T21:24:14Z

Core -> Full Integration Build 11749 outcome was FAILURE using a merge of 13e3181
Summary: Compilation error: Compiler Build time: 00:02:15

darranl · 2022-07-28T09:44:36Z

@fjuma I assume this one will also need an Elytron update to core first?

fjuma · 2022-07-28T13:47:00Z

@darranl Yes, this needs an Elytron component upgrade in Core first. My local test runs have finished successfully so will be tagging Elytron 1.20.0.Final for Core and Elytron 2.0.0.Beta2 for WildFly this morning.

fjuma · 2022-07-28T15:46:53Z

Just FYI, I've submitted the Elytron component upgrade PR that this PR depends on:
#5160

darranl · 2022-07-28T15:49:37Z

@fjuma would you have time to submit a PR merging all the related PRs together so we can get them into CI without waiting for the component upgrade to go in?

fjuma · 2022-07-28T15:51:10Z

@darranl Sure thing, will do that now.

fjuma · 2022-07-28T16:16:16Z

I've created the following aggregate PR:
#5161

yersan · 2022-07-29T13:27:35Z

Merging this as it is since the same SHA 13e3181 passed on the Aggregated PR. I should have merged the aggregate instead of the others separately.

Ashpan mentioned this pull request Apr 6, 2022

[WFLY-16179] Add integrity support to FilesystemSecurityRealm wildfly/wildfly#15411

Merged

yersan added Feature This PR adds a new feature to WildFly missing-reqs This PR is missing external requirements before it can be merged labels Apr 7, 2022

Skyllarr reviewed Apr 12, 2022

View reviewed changes

OndrejKotek reviewed Apr 21, 2022

View reviewed changes

OndrejKotek reviewed Apr 22, 2022

View reviewed changes

fjuma reviewed Apr 25, 2022

View reviewed changes

Ashpan force-pushed the WFCORE-5859 branch from c00984c to 11674bc Compare July 4, 2022 17:01

Ashpan force-pushed the WFCORE-5859 branch from 11674bc to 0914f8a Compare July 26, 2022 14:19

Ashpan force-pushed the WFCORE-5859 branch from 0914f8a to 1ffded8 Compare July 26, 2022 21:04

fjuma and others added 2 commits July 26, 2022 17:17

[WFCORE-5900] Add version 16 of the WildFly Elytron model and schema

194fad9

[WFCORE-5859] Add Filesystem integrity support

13e3181

Ashpan force-pushed the WFCORE-5859 branch from 1ffded8 to 13e3181 Compare July 26, 2022 21:19

Skyllarr approved these changes Jul 28, 2022

View reviewed changes

fjuma approved these changes Jul 28, 2022

View reviewed changes

fjuma mentioned this pull request Jul 28, 2022

[WFCORE-5975] Upgrade WildFly Elytron to 1.20.0.Final #5160

Merged

fjuma mentioned this pull request Jul 28, 2022

Aggregate PR #5161

Closed

darranl removed the missing-reqs This PR is missing external requirements before it can be merged label Jul 29, 2022

yersan merged commit ac384d1 into wildfly:main Jul 29, 2022

[WFCORE-5859] Add Filesystem integrity support #5048

[WFCORE-5859] Add Filesystem integrity support #5048

Conversation

Ashpan commented Apr 6, 2022 • edited

wildfly-ci commented Apr 6, 2022

wildfly-ci commented Apr 6, 2022

luck3y commented Apr 7, 2022

wildfly-ci commented Apr 7, 2022

wildfly-ci commented Apr 7, 2022

luck3y commented Apr 11, 2022

wildfly-ci commented Apr 11, 2022

wildfly-ci commented Apr 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Skyllarr Apr 12, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fjuma Apr 25, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wildfly-ci commented Jul 4, 2022

wildfly-ci commented Jul 4, 2022

wildfly-ci commented Jul 4, 2022

wildfly-ci commented Jul 4, 2022

wildfly-ci commented Jul 4, 2022

wildfly-ci commented Jul 26, 2022

wildfly-ci commented Jul 26, 2022

wildfly-ci commented Jul 26, 2022

wildfly-ci commented Jul 26, 2022

wildfly-ci commented Jul 26, 2022

wildfly-ci commented Jul 26, 2022

darranl commented Jul 28, 2022

fjuma commented Jul 28, 2022

fjuma commented Jul 28, 2022

darranl commented Jul 28, 2022

fjuma commented Jul 28, 2022

fjuma commented Jul 28, 2022

yersan commented Jul 29, 2022

Ashpan commented Apr 6, 2022 •

edited

Skyllarr Apr 12, 2022 •

edited

fjuma Apr 25, 2022 •

edited