[ELY-2752] Ensure it's possible to make use of a custom principal-attribute value for OIDC #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivassile
approved these changes
May 2, 2024
darranl
reviewed
May 13, 2024
| return claimValue; | ||
| } else { | ||
| // fall back to sub claim | ||
| log.principalAttributeClaimDoesNotExist(attr); |
There was a problem hiding this comment.
This looks like it has the potential to become per-request - I am wondering if this should instead be debug information?
There was a problem hiding this comment.
Good catch, I've fixed this, thanks!
…ribute value for OIDC
|
Hi @darranl, I've made the suggested update. Did you want to do a quick pass to make sure this looks good to you now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2752