ELY-2731 Use SecureRandom instead of ThreadLocalRandom #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darranl
reviewed
May 7, 2024
| @@ -0,0 +1,15 @@ | |||
| package org.wildfly.security.password.impl; | |||
There was a problem hiding this comment.
This is missing a copyright header.
darranl
reviewed
May 7, 2024
| } | ||
|
|
||
| static int convertBytesToInt(byte[] saltBytes) { | ||
| if (saltBytes.length != 4) { |
There was a problem hiding this comment.
Can we do something here to use an Assert from wildfly-common?
Having an exception makes me feel this needs to be moved to a message / logger class but TBH as a method internal to this class we know it is unlikely to be anything other than 4 in length so an Assert call sounds safer to protect for the future.
darranl
reviewed
May 7, 2024
| * | ||
| * @return a byte array representing the random salt | ||
| */ | ||
| public static int generateRandomSaltInt() { |
There was a problem hiding this comment.
I know the original was public but maybe reduce the visibility here as only used within this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/ELY-2731