Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-2394] Add the ability to search for blog posts on the Elytron Blogs Page #2056

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gabrielpadilh4
Copy link
Contributor

@gabrielpadilh4 gabrielpadilh4 commented Oct 26, 2023

@fjuma
Copy link
Contributor

fjuma commented Oct 31, 2023

@gabrielpadilh4 Thank you very much for working on this! This is something that we've wanted to see added for quite a while!

@gabrielpadilh4
Copy link
Contributor Author

Hello @PrarthonaPaul can you please review ?

1 similar comment
@gabrielpadilh4
Copy link
Contributor Author

Hello @PrarthonaPaul can you please review ?

@PrarthonaPaul
Copy link
Contributor

Hello @PrarthonaPaul can you please review ?

Hello @gabrielpadilh4
Sorry about the delay.
Your PR looks good to me

Hello @PrarthonaPaul can you please review ?

Hello @gabrielpadilh4
Thank you for the PR. Sorry for the delay.
Would you be able to also add the following changes:

  • When someone searches something, like "oidc" and then deletes it, would it be possible to go back to the original page with all the blogs listed in chronological order?
  • When someone searches multiple terms, like "tls ejb credential-store", would it be possible to do an intersection of the three searches? Currently, it does an union and displays blogs that include "tls or ejb or credential-store"

Thanks!

@gabrielpadilh4
Copy link
Contributor Author

Hey @PrarthonaPaul @fjuma i have done the changes that you have asked. Can you please review it again ? Please let me know if you want to change something else :)

@fjuma
Copy link
Contributor

fjuma commented Dec 15, 2023

Nice, thanks very much @gabrielpadilh4!

One small comment, when searching multiple tags like "oidc bearer", we currently see separate results for each term. Is it possible to only display results that contain both terms or would that be difficult to do?

@gabrielpadilh4
Copy link
Contributor Author

Hi @fjuma i can try to do a cross check of the terms. Allow me sometime to try it out.

@gabrielpadilh4
Copy link
Contributor Author

Hey @fjuma @PrarthonaPaul the problem is that i'm searching in post title and post body, if the post has one of the terms in the title or in the body, it returns as a search result. I can change to only search in the post title, however, it will be limited. What do you think ?

@PrarthonaPaul
Copy link
Contributor

Hello @gabrielpadilh4
I think we would still like it to search both the body AND the title.
However, it would be nice to have the feature act in the following ways:
if the user searches OpenShift and SAML, instead of displaying 2 lists of posts for posts containing OpenShift and one for SAML, it would be nicer if we could display only posts that contain both of those words.
I think for the example above, the list is as follows:
image
but it would be nicer if we could just show:

@gabrielpadilh4
Copy link
Contributor Author

gabrielpadilh4 commented Dec 18, 2023

Hello @PrarthonaPaul @fjuma i have done the change, can you test it again ?

@PrarthonaPaul
Copy link
Contributor

Hello @gabrielpadilh4
Thank you for the quick update.
However, I am not sure if it is doing the filtering correctly (at least on my end).
It seems like when you search 2 or more terms, it displays the results of the last term. (try "SAML OpenSHIFT EJB").
What do you think @fjuma ?

_includes/search.html Outdated Show resolved Hide resolved
ELY-2394 Add the ability to search for blog posts on the Elytron Blog…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants