[1.15.x][ELY-2362] Add support for the bearer-only option when using the OIDC HTTP mechanism #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y parameter can be processed appropriately
…ials obtained from Basic auth
Method isAutodetectedBearerOnly() should be invoked after checking cached token. Invoking isAutodetectedBearerOnly() early will break every AJAX request that relies on HTTP session. A clear example is JSF Partial Request, it will never send the header "Authorization" neither the query parameter "auth". During the initial load of view the user was authenticated, then the token was stored in HTTP session, so, JSF Partial Request relies on HTTP session onwards. https://issues.redhat.com/browse/ELY-2487
Signed-off-by: Patrick Reinhart <patrick@reini.net>
fjuma
changed the title
darranl
approved these changes
Jun 14, 2023
Skyllarr
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2362
https://issues.redhat.com/browse/JBEAP-24828
This PR backports the support for the bearer-only option along with other related bug fixes.
Upstream PRs:
#1735 (bearer-only support)
#1739 (Azure specific fixes)
#1829 (bearer-only fix)
#1671 (OIDC roles fix)
Related ELY issues:
https://issues.redhat.com/browse/ELY-2356
https://issues.redhat.com/browse/ELY-2357
https://issues.redhat.com/browse/ELY-2487
https://issues.redhat.com/browse/ELY-2303